I have an upcoming visa appointment, however my passport expires?
They're not going to put a visa in an expired passport, so of course you will need to replace it before your appointment. If the old passport number has been used in the application then yes, you will want to have it returned and take it with you to the appointment.